Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WidgetRenderer: Soften manager type requirement #3625

Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Oct 27, 2022

This way we can use a WidgetRenderer with a KernelWidgetManager as well

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch martinRenou/ipywidgets/soften_manager_requirement

martinRenou added a commit to jtpio/voila that referenced this pull request Oct 27, 2022
We need to cast "as any" until this is merged and released: jupyter-widgets/ipywidgets#3625
trungleduc added a commit to voila-dashboards/voila that referenced this pull request Oct 27, 2022
* Switch to a lab-based app for the Voila frontend

Co-authored-by: martinRenou <[email protected]>

* Remove `"private": true` in  `voila/package.json`

* Minor updates

* Convert `index.js` into typescript

* Pass "this" to the WidgetRenderer

We need to cast "as any" until this is merged and released: jupyter-widgets/ipywidgets#3625

* Remove install --pre ipywidgets

* Update snapshots

* Remove ipyvolume ui-test

Co-authored-by: martinRenou <[email protected]>
Co-authored-by: Duc Trung LE <[email protected]>
@jasongrout jasongrout requested a review from ibdafna November 1, 2022 16:44
Copy link
Member

@ibdafna ibdafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ibdafna ibdafna merged commit c5103e4 into jupyter-widgets:master Nov 6, 2022
@martinRenou martinRenou deleted the soften_manager_requirement branch November 7, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants