Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notebook specific custom widget tutorial #2677

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 7, 2020

Fixes #2379.

Remove the custom widget tutorial since it is specific to the classic notebook, and not the recommended way to build custom widgets.

Instead, there could be a tutorial similar to the Let’s Make an Astronomy Picture of the Day JupyterLab Extension, that is based on the TypeScript cookiecutter.

@jtpio
Copy link
Member Author

jtpio commented Jan 7, 2020

Leaving that one as a draft for now, as we might want to convert it to the cookiecutter based tutorial in the same change.

Also happy to have it merged right now if it is considered useful to have the "old" tutorial removed from the docs earlier.

@jtpio jtpio added the docs label Jan 7, 2020
@SylvainCorlay SylvainCorlay added this to the 8.0 milestone Jan 8, 2020
@jasongrout jasongrout self-assigned this Jan 8, 2020
@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout marked this pull request as ready for review January 11, 2020 02:08
@jasongrout jasongrout force-pushed the custom-widget-tutorial branch from 18098a9 to e87bff4 Compare January 11, 2020 02:15
@jasongrout
Copy link
Member

I rebased on current master to fix merge conflicts.

@jasongrout jasongrout merged commit 5343523 into jupyter-widgets:master Jan 11, 2020
@jtpio jtpio deleted the custom-widget-tutorial branch January 11, 2020 10:51
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript Error: define is not defined
3 participants