Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign RTD builds for 8.0 master branch and 7.x branch #3093

Closed
willingc opened this issue Feb 6, 2021 · 6 comments · Fixed by #3094
Closed

Realign RTD builds for 8.0 master branch and 7.x branch #3093

willingc opened this issue Feb 6, 2021 · 6 comments · Fixed by #3094
Assignees
Labels

Comments

@willingc
Copy link
Contributor

willingc commented Feb 6, 2021

I've got RTD building both branches properly again on PR merge. The requirements.txt for master and 7.x environment.yml diverged somewhere along the road. Ideally, this should be the same file on both branches.

@ianhi
Copy link
Contributor

ianhi commented Feb 7, 2021

The builds seems to be broken on master again :(

In #2919 it seems to have failed as the docs/requirement includes ipyleaflet which hold ipywidgets<8

https://readthedocs.org/projects/ipywidgets/builds/12956312/

https://github.com/jupyter-widgets/ipyleaflet/blob/e3c63cdfdc41f53d8e21788213015afe3e8f88c6/setup.py#L62

I think the short term solution may be to drop the ipyleaflet from the docs.

@willingc
Copy link
Contributor Author

willingc commented Feb 7, 2021

@ianhi Can you point out the exact examples that use ipyleaflet? I haven't yet made any changes to the requirements themselves. PR #3094 only changes the 7.x branch.

@jasongrout
Copy link
Member

@ianhi
Copy link
Contributor

ianhi commented Feb 7, 2021

Given that the notebook isn't actually accessible by following links in the TOC (I could only find it by searching for ipyleaflet - xref #3097) and that it has line explaining how it depends on extra packages how about removing those packages from the doc/requirements?

@ianhi
Copy link
Contributor

ianhi commented Feb 7, 2021

Indeed, removing only ipyleaflet from the requirements.txt fixes the build on master: #3098

@willingc
Copy link
Contributor Author

willingc commented Feb 7, 2021

@jasongrout I've merged @ianhi pr removing ipyleaflet. Removing from 7.x branch as well in #3094

@willingc willingc closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants