Unable to open Notebook without metadata

[martinRenou]

Description

I am getting the following:

    Traceback (most recent call last):
      File "/home/martinrenou/micromamba/envs/glue-lab/lib/python3.11/site-packages/tornado/websocket.py", line 944, in _accept_connection
        await open_result
      File "/home/martinrenou/micromamba/envs/glue-lab/lib/python3.11/site-packages/jupyter_collaboration/handlers.py", line 236, in open
        if self.room.document.source != model["content"]:
           ^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/martinrenou/micromamba/envs/glue-lab/lib/python3.11/site-packages/jupyter_ydoc/ybasedoc.py", line 60, in source
        return self.get()
               ^^^^^^^^^^
      File "/home/martinrenou/micromamba/envs/glue-lab/lib/python3.11/site-packages/jupyter_ydoc/ynotebook.py", line 213, in get
        metadata=meta["metadata"],
                 ~~~~^^^^^^^^^^^^
    KeyError: 'metadata'

Leading to not being able to open the Notebook (it's an empty area on Jupyterlab)

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[fcollonval]

We could certainly fix it. But such notebook is invalid:

https://github.com/jupyter/nbformat/blob/633a433d13436247c5994f571911c74a1ec507d4/nbformat/v4/nbformat.v4.5.schema.json#L6

[martinRenou]

It's unclear to me as to why I ended up with this invalid Notebook though

[hbcarlos]

Hi @martinRenou. What version of jupyter_ydoc are you using?

In theory, this was fixed in #158

[martinRenou]

I'm using 1.0.2

[fcollonval]

Did you played with your local installation? The reported line number in the error is not consistent with the code.

Line 213 of ynotebook at v1.0.2 is:

jupyter_ydoc/jupyter_ydoc/ynotebook.py

Line 213 in 39ddee8

if (

Metadata query is at line 223 in v1.0.2:

jupyter_ydoc/jupyter_ydoc/ynotebook.py

Line 223 in 39ddee8

metadata=meta.get("metadata", {}),

Could you try forcing a re installation?

[martinRenou]

Indeed 🤔

code /home/martinrenou/micromamba/envs/glue-lab/lib/python3.11/site-packages/jupyter_ydoc/ynotebook.py

gives me

So I'd say the traceback is lying!

[fcollonval]

You may be trolled by inconsistent byte-code version. Do you get .pyc files for ynotebook.py. If so you could give a try of removing them.