Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YDirectory #128

Open
davidbrochart opened this issue Jan 16, 2023 · 3 comments
Open

Add YDirectory #128

davidbrochart opened this issue Jan 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@davidbrochart
Copy link
Collaborator

Problem

Currently in RTC mode, directories are handled differently than files. The latter use the YDocWebSocketHandler, while the former use HTTP.
With jupyterlab/jupyterlab#13527, JupyterLab drives will use the y-websocket, that will allow to drop the HTTP API for directories.

Proposed Solution

I think we should create a new YDirectory document for these "collaborative drives". It will allow listing directories, renaming/deleting files and directories, etc.

@davidbrochart davidbrochart added the enhancement New feature or request label Jan 16, 2023
@hbcarlos
Copy link
Contributor

I'm improving the IDrive interface and extracting RTC into an extension. Once this is done, we can implement the YDirectory without disruptions in JupyterLab.

@davidbrochart
Copy link
Collaborator Author

Maybe a YDirectory should not be independent from the files that are being edited. The Yjs documentation has an example of file contents "mounted" on the directory document as subdocuments. It would make the "drive" a consistent document for everything stored on disk: listing directories, moving/renaming/deleting files or directories, as well as editing file contents.

cc @ellisonbg @dmonad

@davidbrochart
Copy link
Collaborator Author

I started working on that in jupyter-server/jupyverse#370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants