[Gateway] Fix and deprecate env whitelist handling #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I learned that Lab includes the user's env in the
env
stanza of the kernel start request body. I also learned that we were only filtering the server's env (i.e., the env of the jupyter server process) when applying theenv_whitelist
configurable to determine which envs to send to the gateway, then unconditionally adding whatever was already in the start request'senv
stanza. Instead, we need to be filtering both the server's envs and the provided envs against the configured list. This pull request makes this change.Also, while we're at it, we should deprecate
env_whitelist
in favor ofallowed_envs
- similar to what was done with Kernelspec filtering in jupyter_client. This pull request makes that change as well.