Fix error that prevents posting to api/contents endpoint with no body

[kiersten-stokes]

Fixes #931

This is a small refactor to avoid a 'NoneType' AttributeError when sending a POST request to api/contents that does not include a body.

A body-less POST to the api/contents/{path} endpoint is also added to services/contents/test_api.py:test_create_untitled.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[kevin-bates]

LGTM - confirmed the test reproduces the issue prior to this change and the changes fix the issue. Thanks @kiersten-stokes!

[codecov-commenter]

Codecov Report

Merging #937 (2b1126c) into main (f373286) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   72.28%   72.20%   -0.08%     
==========================================
  Files          65       65              
  Lines        8002     8001       -1     
  Branches     1336     1333       -3     
==========================================
- Hits         5784     5777       -7     
- Misses       1811     1814       +3     
- Partials      407      410       +3     

Impacted Files	Coverage Δ
jupyter_server/services/contents/handlers.py	86.63% <100.00%> (+0.99%)	⬆️
jupyter_server/services/contents/filemanager.py	70.61% <0.00%> (-0.79%)	⬇️
jupyter_server/services/kernels/kernelmanager.py	77.99% <0.00%> (-0.65%)	⬇️
jupyter_server/serverapp.py	65.48% <0.00%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f373286...2b1126c. Read the comment docs.

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[blink1073]

@meeseeksdev please backport to 1.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 1.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 426d9968233dc905b7909fdf98e87c5fe7069221

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #937: Fix error that prevents posting to `api/contents` endpoint with no body'

4. Push to a named branch:

git push YOURFORK 1.x:auto-backport-of-pr-937-on-1.x

5. Create a PR against branch 1.x, I would have named this PR:

"Backport PR #937 on branch 1.x (Fix error that prevents posting to api/contents endpoint with no body)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[vidartf]

Shouldn't this path only trigger if copy_from is false?

[kiersten-stokes]

Shoot, yeah good catch - looks like a follow-up is in order!

[kevin-bates]

Thanks @vidartf - I apologize for not catching this as well.