-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to jupyter_events #862
Conversation
Codecov Report
@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 65 65
Lines 8044 8044
Branches 1343 1343
=======================================
Hits 5802 5802
Misses 1836 1836
Partials 406 406 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@jupyter-server/jupyter-server-council this should be ready to go. Would someone mind reviewing+merging? |
Are we not renaming "categories" first? |
Ah, right. Yeah, let's settle that in |
fcc2c18
to
a4fc7f4
Compare
Looks good! The changes are pretty lean, so I say we can just merge this after the pipeline passes. Took a quick look at the failing tests here: https://github.com/jupyter-server/jupyter_server/runs/8020778443?check_suite_focus=true. It looks like there's an error when trying to dereference |
@Zsailer BTW, have we established a convention for where to place event schemas within the |
Replaces
jupyter_telemetry
withjupyter_events
.Telemetry is a more specific use case of the Jupyter Event System mentioned in #780, and it brings some extra constraints that won't be addressed by the (currently available) "event system" use-case. Telemetry might be added to Jupyter Server at a later time.