Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in release instructions #1003

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

kevin-bates
Copy link
Member

While looking into adopting recent build framework changes in another repo, I ran into a couple of (minor) issues with the recently-added hatchling instructions. I also took the liberty to update the variable script_version to new_version to have parity with its prompt (as well as dev_version).

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.59%. Comparing base (5eb977c) to head (613ffc7).
Report is 340 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files          64       64           
  Lines        8249     8249           
  Branches     1378     1378           
=======================================
  Hits         5988     5988           
  Misses       1847     1847           
  Partials      414      414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit fc2d2cd into jupyter-server:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants