-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing nbconvert
as a required dependency
#1388
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
It's unlikely this is going to be accepted in jupyter-server, as it is a Jupyter server that comes with "essential" functionalities that dependencies expect, and nbconvert is one of them. |
Seems making it a separate server extension is more reasonable. As nbconvert need more configuration when using LaTeX. |
I think making it a server extension is a reasonable ask. We made a similar call with the terminals and mathjax APIs in Jupyter Server a few years back. I agree that nbconvert feels more like an optional feature of Jupyter Server than a necessary requirement for a minimal Jupyter Server (there has been a lot of discussion previously about what makes a minimal Jupyter Server). If you're really interested in separating out nbconvert, I think we could get this done without much resistance. We just need fingers at the keyboard. Practically, the approach we took for e.g. terminals was:
By doing this, we would introduce a non-breaking change that would allow folks to at least disable nbconvert. In future (major) releases of Jupyter Server, we could drop the dependency if folks agree. |
Problem
I have
jupyterlab
as a dependency, which depends onjupyter-server
, which installsnbconvert
.Can we move
nbconvert
to an optional dependency via an extra?The source code in https://github.com/jupyter-server/jupyter_server/tree/v2.12.5/jupyter_server/nbconvert already doesn't require it at import time, so the code is already compatible with this.
It seems #15 is related.
Proposed Solution
nbconvert
to an optionalextra
nbconvert
as a test dependencyAdditional context
N/a
The text was updated successfully, but these errors were encountered: