Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 #394

Closed
blink1073 opened this issue Sep 23, 2022 · 8 comments
Closed

Version 2 #394

blink1073 opened this issue Sep 23, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@blink1073
Copy link
Contributor

blink1073 commented Sep 23, 2022

I've created a https://github.com/jupyter-server/jupyter_releaser/tree/version2 branch to target breaking changes to the workflows and actions.

I'll test the v2 changes against Jupyter Server with the workflows being on Jupyter Server itself before declaring this done and merging into main. Whatever state main is in at that time will become the v1 branch.

@blink1073 blink1073 added the enhancement New feature or request label Sep 23, 2022
@blink1073 blink1073 pinned this issue Sep 23, 2022
@blink1073
Copy link
Contributor Author

First successful release! https://github.com/blink1073/test-python-project/actions/runs/3123150680. The changelog entry is wrong, but progress!

@blink1073
Copy link
Contributor Author

Okay now fully working! https://github.com/blink1073/test-python-project/actions/runs/3123516914

I'll try with Jupyter Server tomorrow.

@blink1073
Copy link
Contributor Author

Woohoo! https://github.com/jupyter-server/jupyter_server/releases/tag/v2.0.0rc1

All that's left is docs. I'll remove the screen shots and focus on the text. We can follow up with replacement screen shots.

@blink1073
Copy link
Contributor Author

blink1073 commented Sep 30, 2022

Updated plan:

@blink1073
Copy link
Contributor Author

Okay, I think we're good on the security front. In this workflow we see that my admin status was verified ("User was admin!"), and the commit is in my name.

@blink1073
Copy link
Contributor Author

Here's a dump of some updated screenshots:

Run workflow

prep release (3,10) summary

Run workflow

publish_release (3 10) summary

v1 0 0a4

Run workflow

Releases  v0 1 12

Run workflow

@blink1073
Copy link
Contributor Author

I'll publish a 1.0 of the python package next week, open a new issue tracking the blog post, and then close this issue.

@blink1073 blink1073 unpinned this issue Nov 7, 2022
@blink1073
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant