Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error releasing jupyter_server_ydoc #346

Closed
davidbrochart opened this issue Jul 10, 2022 · 9 comments
Closed

Error releasing jupyter_server_ydoc #346

davidbrochart opened this issue Jul 10, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@davidbrochart
Copy link
Contributor

Description

While trying to make a full release of jupyter_server_ydoc I got this error message:

--------------------------------------------------
check-changelog
--------------------------------------------------
COMMAND: git --no-pager tag --sort=-creatordate --merged refs/heads/main
v0.1.1
Getting changes to jupyter-server/jupyter_server_ydoc since v0.1.1 on branch main...
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/github_activity/github_activity.py", line 549, in _get_datetime_and_type
    dt = _get_datetime_from_git_ref(org, repo, datetime_or_git_ref, auth)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/github_activity/github_activity.py", line 568, in _get_datetime_from_git_ref
    response.raise_for_status()
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://api.github.com/repos/jupyter-server/jupyter_server_ydoc/commits/v0.1.1
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/github_activity/github_activity.py", line 553, in _get_datetime_and_type
    dt = dateutil.parser.parse(datetime_or_git_ref)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/dateutil/parser/_parser.py", line 1368, in parse
    return DEFAULTPARSER.parse(timestr, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/dateutil/parser/_parser.py", line 643, in parse
    raise ParserError("Unknown string format: %s", timestr)
dateutil.parser._parser.ParserError: Unknown string format: v0.1.1
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.5/x64/bin/jupyter-releaser", line 8, in <module>
    sys.exit(main())
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/cli.py", line 99, in invoke
    super().invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/cli.py", line 412, in check_changelog
    changelog.check_entry(
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/changelog.py", line 251, in check_entry
    raw_entry = get_version_entry(
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/changelog.py", line 96, in get_version_entry
    md = generate_activity_md(
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/github_activity/github_activity.py", line 228, in generate_activity_md
    data = get_activity(
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/github_activity/github_activity.py", line 119, in get_activity
    since_dt, since_is_git_ref = _get_datetime_and_type(org, repo, since, auth)
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/github_activity/github_activity.py", line 556, in _get_datetime_and_type
    raise ValueError(
ValueError: v0.1.1 not found as a ref or valid date format
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/actions/draft_release.py", line 81, in <module>
    run_action("jupyter-releaser check-changelog")
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/actions/common.py", line 36, in run_action
    _run(target, *args, **kwargs)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/util.py", line 88, in run
    raise e
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/util.py", line 80, in run
    process = tee(cmd, **kwargs)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/tee.py", line 155, in run
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command 'jupyter-releaser check-changelog' returned non-zero exit status 1.

Not sure if it's because it's the first release or the changelog has an issue?

@davidbrochart davidbrochart added the bug Something isn't working label Jul 10, 2022
@blink1073
Copy link
Contributor

I think this is related to changes made in #341 or #343. I have been trying to figure out a way to make all of this work, I think the solution is to drop support for dev mode handling until we implement #272 (comment).

@blink1073
Copy link
Contributor

For now you can skip check-changelog when you run the workflow (under Comma separated list of steps to skip)

@davidbrochart
Copy link
Contributor Author

Thanks, that worked.

@davidbrochart
Copy link
Contributor Author

Note that the check_release fails with:

ERROR: No matching distribution found for ypy-websocket>=0.1.23

Which is strange because it requires ypy-websocket>=0.1.13.

@davidbrochart
Copy link
Contributor Author

I tried skipping check-changelog and check-python but I cannot release jupyter_server_ydoc anymore. I get:

ERROR: No matching distribution found for jupyter-ydoc==0.1.23

While I require jupyter_ydoc==0.1.13.

@blink1073
Copy link
Contributor

That is coming from this line.

@davidbrochart
Copy link
Contributor Author

Wow, that was changed by the by the action.

@blink1073
Copy link
Contributor

Ah, yikes, I'd suggest adding a version template here that includes "version ="

@davidbrochart
Copy link
Contributor Author

Closing, as this was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants