Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure so that only one signature suggestion shows #619

Closed
chenyulue opened this issue Jun 5, 2021 · 3 comments · Fixed by #671
Closed

How to configure so that only one signature suggestion shows #619

chenyulue opened this issue Jun 5, 2021 · 3 comments · Fixed by #671
Labels
bug Something isn't working
Milestone

Comments

@chenyulue
Copy link

chenyulue commented Jun 5, 2021

It's fine to automatically give a signature suggestions when I type a function.

However, in my case, two signature suggestion dialogs are displayed as follows:

signature

Actually, the bottom one shows when I type the function name sum, while the top one shows when I finished typing the parentheses. If I type slowly, the two dialogs show in turn; if i type fast, then the two dialogs shows simultaneously, which really bothers my typing.

I install jupyterlab-lsp according to the installation instruction in the readme.md, choosing pylsp as the language server.

My question is how to configure so that only one signagure suggestion is displayed. Thanks!

@krassowski
Copy link
Member

Thank you for the report. This looks like a bug that should be fixed - it should only show the signature popover rather than both:

  • completer (which includes documentation), and
  • signature popover

if i type fast, then the two dialogs shows simultaneously, which really bothers my typing.

This means we do not cancel the completer request properly if it arrives late (after the cursor has moved). Should be possible to fix for the next release.

Sorry about the bad experience!

@krassowski krassowski added the bug Something isn't working label Jun 5, 2021
@chenyulue
Copy link
Author

@krassowski Look forward to the next release!

@krassowski
Copy link
Member

I ended up implementing a different solution in #671: the signature will show up above (if possible) and the completer will be able to co-exist with the signature. I am also adding highlighting of the current argument and better choice of active signature:

Screenshot from 2021-08-30 16-19-34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants