Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinfo2 substitution does not work for variables with s #542

Closed
krassowski opened this issue Feb 23, 2021 · 1 comment · Fixed by #547
Closed

pinfo2 substitution does not work for variables with s #542

krassowski opened this issue Feb 23, 2021 · 1 comment · Fixed by #547
Assignees
@krassowski
Labels
bug Something isn't working lang:python Python, pyls, etc

Comments

@krassowski
Copy link
Member

krassowski commented Feb 23, 2021 •
edited
Loading

Description

open??

Gets correctly transformed to:

get_ipython().run_line_magic('pinfo2',  'open')

but

stat_distribution??

does not get transformed and results in a syntax error for Python servers that do not know about IPython syntax.

Context

  • JupyterLab version: 3.0.8
  • @krassowski/jupyterlab-lsp v3.4.0 enabled OK (python, jupyterlab_lsp)
@krassowski krassowski added lang:python Python, pyls, etc bug Something isn't working labels Feb 23, 2021
@bollwyvl
Copy link
Collaborator

What's the .virtual_document look like?

@krassowski krassowski self-assigned this Feb 23, 2021
@krassowski krassowski changed the title pinfo2 substitution does not work for variables with underscores pinfo2 substitution does not work for variables with s Feb 24, 2021
@krassowski krassowski mentioned this issue Feb 24, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krassowski krassowski

Labels
bug Something isn't working lang:python Python, pyls, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a typo preventing pinfo from working on ids with letter 's' jupyter-lsp/jupyterlab-lsp
2 participants
@bollwyvl @krassowski