Refactor how the notebook changes are picked up, events bound and unbound #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the binding of events was only performed upon the user entering a code cell. Moreover, updates to the virtual document were only triggered on code edition, and not on cell edition (rearrangement, cell pasting etc). This was kind-of ok for the initial demo, but a number of scenarios require a better management of the events binding [E] and document updates [D]:
Overall this small refactoring has a hug potential to squash numerous bugs and stability issues that arouse only after a longer work with a notebook (i.e. involving the use of feature such as moving cells, pasting, conversion of types) and were difficult to pinpoint so far.
References
Fixes #393.
Code changes
editorAdded
andeditorRemoved
events toWidgetAdapter
.Notebook.model.cells
and trigger document updates, or editor events from there, as needed.User-facing changes
Plus pasting of cells works better with LSP, but a third set of GIFs would be redundant.
Backwards-incompatible changes
None
Chores