Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting in hover tooltips and start testing the hover feature #363

Merged
merged 15 commits into from
Sep 18, 2020

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Sep 14, 2020

References

A step towards #297

Code changes

  • Fixed missing new lines in markdown generation which were causing the code in the tooltips to be rendered without syntax highlighting
  • Added setting for hover tooltip debouncer.
  • Removed unneeded margin/padding on the bottom and right side of the tooltip
  • Added className option to the custom tooltip subclass
  • Added tests for hover in notebooks; they check that the syntax highlighting is correctly applied
  • Fix the underline
  • Improve multi-element hover display (deprecated API)

User-facing changes

before after
before_lsp after_hover

Final:
hover

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@krassowski krassowski changed the title Fix highlighting in hover tooltips and start them Fix highlighting in hover tooltips and start testing the hover feature Sep 14, 2020
@krassowski
Copy link
Member Author

krassowski commented Sep 14, 2020

Actually, we used to get these nice underlines indicating whether hover is available or not. This seems to be broken in 2.0.

  • css is in place
  • hover marker is getting set... theoretically...

@krassowski
Copy link
Member Author

krassowski commented Sep 15, 2020

Underlines are now fixed; the only remaining problem is with tests. Everything works well locally but the tests are slow and flaky beyond reason.

TODO:

  • try action chains
  • if action chains fail, fallback to testing delay-based trigger only (which needs to be implemented first!)
  • update changelog (either 2.0.7 or 2.1)
  • record new gif, ideally showing when ctrl is being preseed
  • do not trigger if not over a token (but after it) - could accelerate the overall responsiveness in large documents

@krassowski krassowski added the help wanted Extra attention is needed label Sep 16, 2020
@krassowski
Copy link
Member Author

@bollwyvl, how would you approach the action chains issue? There is https://github.com/hmalphettes/robotframework-selenium2library-extensions but it was not updated in ages nor released. We could try to extend SeleniumLibrary https://github.com/robotframework/SeleniumLibrary/blob/master/docs/extending/extending.rst (lot's of reading it seems, no time at the moment..)

@bollwyvl
Copy link
Collaborator

bollwyvl commented Sep 17, 2020 via email

@krassowski krassowski removed the help wanted Extra attention is needed label Sep 17, 2020
@krassowski krassowski merged commit 22e2be7 into master Sep 18, 2020
@krassowski krassowski deleted the fix-hover branch February 16, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants