-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix highlighting in hover tooltips and start testing the hover feature #363
Conversation
Actually, we used to get these nice underlines indicating whether hover is available or not. This seems to be broken in 2.0.
|
Underlines are now fixed; the only remaining problem is with tests. Everything works well locally but the tests are slow and flaky beyond reason. TODO:
|
constrain feature events wrappers types
@bollwyvl, how would you approach the action chains issue? There is https://github.com/hmalphettes/robotframework-selenium2library-extensions but it was not updated in ages nor released. We could try to extend SeleniumLibrary https://github.com/robotframework/SeleniumLibrary/blob/master/docs/extending/extending.rst (lot's of reading it seems, no time at the moment..) |
Sorry, didn't have a chance to dig into this yet, nor have I been able to
find my old code.
I'd probably make a quick and dirty library that used raw selenium stuff,
e.g. hover_with_modifier(selector, modifier=None) and hide the action chain
stuff in there. We should not take that library you mention as a
dependency, it's caused me issues in the past.
Speaking if freaky dependencies: I have also been looking into:
https://github.com/MarketSquare/robotframework-browser
...which uses the nodejs-based playwright, which theoretically supports
more browsers, though with less control, with more rando binary blobs.
Anyhow, its "Hover" keyword already accepts modifiers:
*https://marketsquare.github.io/robotframework-browser/Browser.html#Hover
<https://marketsquare.github.io/robotframework-browser/Browser.html#Hover>*
I'll be trying it out on some greenfield stuff, and if it's useful, looking
into packaging it, yadda yadda.
|
add test for key-based trigger, removed unused variables, return early if possible, move unpacking before loop
References
A step towards #297
Code changes
className
option to the custom tooltip subclassUser-facing changes
Final:
Backwards-incompatible changes
None
Chores