Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually test Windows vs Python 3.8 #188

Closed
bollwyvl opened this issue Feb 2, 2020 · 2 comments
Closed

Actually test Windows vs Python 3.8 #188

bollwyvl opened this issue Feb 2, 2020 · 2 comments
Labels
dependencies Pull requests that update a dependency file package:jupyter-lsp

Comments

@bollwyvl
Copy link
Collaborator

bollwyvl commented Feb 2, 2020

Elevator Pitch

Test full functionality on python 3.8 running on windows.

Motivation

Upstream we finally got pypi and conda-forge versions of the whole stack up for python 3.8 on windows (and ppc/aarch, but let's not get ahead of ourselves). 3.9 is already in beta 3 or something, but that, too, is for another day.

Design Ideas

Uncomment all of the test skips for python 3.8 on windows.
@bollwyvl bollwyvl added dependencies Pull requests that update a dependency file package:jupyter-lsp labels Feb 2, 2020
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Feb 4, 2020

Added on #165 (33b1b04)

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Feb 9, 2020

Closed by #165

@bollwyvl bollwyvl closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file package:jupyter-lsp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bollwyvl