From 26fb4639c77cfff769f0a72612d3bdb74230ffd2 Mon Sep 17 00:00:00 2001 From: Matthias Bussonnier Date: Tue, 27 Apr 2021 13:50:36 -0700 Subject: [PATCH] Rename options --- README.md | 4 ++-- packages/jupyterlab-lsp/schema/completion.json | 2 +- .../src/features/completion/completion_handler.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 8e02d6ec1..2ebb0f05b 100644 --- a/README.md +++ b/README.md @@ -66,8 +66,8 @@ from the Language Server (in notebook). If the kernel is too slow to respond promptly only the Language Server suggestions will be shown (default threshold: 0.6s). You can configure the completer to not attempt to fetch the kernel completions if the kernel is busy (skipping the 0.6s timeout). -You can deactivate the kernel suggestions by adding `"kenel"` to the `disableCompletionsFrom` in the `completion` section -of _Advanced Settings_. Alternatively if you _only_ want kernel completions you can add `"languageServer"` to the same +You can deactivate the kernel suggestions by adding `"Kernel"` to the `disableCompletionsFrom` in the `completion` section +of _Advanced Settings_. Alternatively if you _only_ want kernel completions you can add `"LSP"` to the same setting; Or add both if you like to code in hardcore mode and get no completions, or if another provider has been added. ### Rename diff --git a/packages/jupyterlab-lsp/schema/completion.json b/packages/jupyterlab-lsp/schema/completion.json index 808d35b63..5f057bd56 100644 --- a/packages/jupyterlab-lsp/schema/completion.json +++ b/packages/jupyterlab-lsp/schema/completion.json @@ -42,7 +42,7 @@ "description": "The time to wait for the kernel completions suggestions in milliseconds. Set to 0 to disable kernel completions, or to -1 to wait indefinitely (not recommended)." }, "disableCompletionsFrom": { - "description": "The sources from which to exclude completion from. Possible values include 'kernel', 'languageServer'.", + "description": "The sources from which to exclude completion from. Possible values include 'Kernel', 'LSP'.", "type": "array", "default": [], "uniqueItems": true diff --git a/packages/jupyterlab-lsp/src/features/completion/completion_handler.ts b/packages/jupyterlab-lsp/src/features/completion/completion_handler.ts index 360af7d59..0323b0a28 100644 --- a/packages/jupyterlab-lsp/src/features/completion/completion_handler.ts +++ b/packages/jupyterlab-lsp/src/features/completion/completion_handler.ts @@ -81,7 +81,7 @@ export class LSPConnector protected get use_lsp_completions(): boolean { return ( this.options.settings.composite.disableCompletionsFrom.indexOf( - 'languageServer' + 'LSP' ) == -1 ); } @@ -89,7 +89,7 @@ export class LSPConnector protected get use_kernel_completions(): boolean { return ( this.options.settings.composite.disableCompletionsFrom.indexOf( - 'kernel' + 'Kernel' ) == -1 ); }