From 541a3774eee8b62a4d27c7a48c990afd9ceffecd Mon Sep 17 00:00:00 2001 From: krassowski Date: Mon, 28 Oct 2019 03:03:20 +0000 Subject: [PATCH 1/3] Fix hanging connections for additional virtual documents --- src/adapters/jupyterlab/jl_adapter.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/adapters/jupyterlab/jl_adapter.ts b/src/adapters/jupyterlab/jl_adapter.ts index f13ff8eee..1ed65d6e7 100644 --- a/src/adapters/jupyterlab/jl_adapter.ts +++ b/src/adapters/jupyterlab/jl_adapter.ts @@ -80,7 +80,7 @@ export abstract class JupyterLabWidgetAdapter >; protected abstract current_completion_connector: LSPConnector; private _tooltip: FreeTooltip; - protected connection_manager: DocumentConnectionManager; + public connection_manager: DocumentConnectionManager; protected constructor( protected app: JupyterFrontEnd, @@ -188,6 +188,10 @@ export abstract class JupyterLabWidgetAdapter this.connection_manager.connect_document_signals(virtual_document); virtual_document.changed.connect(this.document_changed.bind(this)); await this.connect(virtual_document).catch(console.warn); + + virtual_document.foreign_document_opened.connect((host, context) => { + this.connect(context.foreign_document).catch(console.warn); + }); } document_changed(virtual_document: VirtualDocument) { From a0169afae74c6516d80f296fcda9f6326c1e4b14 Mon Sep 17 00:00:00 2001 From: krassowski Date: Mon, 28 Oct 2019 03:22:34 +0000 Subject: [PATCH 2/3] Publish 0.6.0 (very soft release) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index faf3b36c7..87668b25c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@krassowski/jupyterlab-lsp", - "version": "0.5.0", + "version": "0.6.0", "description": "Language Server Protocol integration for JupyterLab", "keywords": [ "jupyter", From 903ee469c8e4cf9bd986f1ae61e0726f3fe40ab8 Mon Sep 17 00:00:00 2001 From: Nicholas Bollweg Date: Mon, 28 Oct 2019 00:16:24 -0400 Subject: [PATCH 3/3] bump ci to 0.6.0 --- azure-pipelines.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 95cf7ebb1..9501152bf 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -12,7 +12,7 @@ variables: PYTHONUNBUFFERED: 1 YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn PY_JLSP_VERSION: 0.6.0b0 - JS_JLLSP_VERSION: 0.5.0 + JS_JLLSP_VERSION: 0.6.0 jobs: - template: ci/job.test.yml