Support nbclassic while updating the static path #141
Conversation
|
While this works fine when the user clicks on the menu to show the configurator page (http://localhost:8888/tree?#nbextensions_configurator), it does not solve the issue when the user directly types in his browser http://localhost:8888/nbextensions This can however be merged as a step towards a more complete solution. |
|
This PR is ready for review. |
|
LGTM |
|
@juhasch Have you bandwidth to review and help with this? Anyone else interested to have a look? Thx! |
|
I am adding @damianavila as potential reviewer of this PR (just seeing Damian is part of this Happy to answer any question on these changes which are fully backwards compatible. |
|
@juhasch would be a better reviewer than me since I have not been connected with the codebase for a loooong time. Juergen, WDYT about this one? I presume this one would also need a release as well... |
|
Thx @damianavila for the comment. @juhasch Do you have any question on this change. It is working fine on my env for notebook 6.4.x, 6.5.x and nbclassic. |
|
Sorry for replying so late, I am mostly off Github currently. Let me take a look what to do. |
|
Thank you for your patience @echarles |
|
Super! Thx you for taking time to review and merge @juhasch I wonder what are the plans for a release? Would you like me to open an issue for that? |
|
We should do a release quickly, I think. If you open a PR that would be great. |
I am not sure what content the PR should have. Do I have to just bump the version? |
|
Just bump the version and update the readme (changes section). That should be enough. |
|
Thx @juhasch. I have opened https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/143/files for that. |
|
Folks, created #146 to further discuss adding more maintainers to this project. |
Fixes jupyter/nbclassic#140
This PR ensure that
jupyter_nbextensions_configuratorcan also run on the latest nbclassic.