fix: do not panic on nil object (#21)

go-simpler · Feb 11, 2023 · 2ad105d · 2ad105d
1 parent 27a84af
commit 2ad105d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/musttag.go b/musttag.go
@@ -160,6 +160,9 @@ func run(pass *analysis.Pass, funcs map[string]Func) (any, error) {
 		initialPos := token.NoPos
 		switch arg := arg.(type) {
 		case *ast.Ident: // e.g. json.Marshal(foo)
+			if arg.Obj == nil {
+				return // e.g. json.Marshal(nil)
+			}
 			initialPos = arg.Obj.Pos()
 		case *ast.CompositeLit: // e.g. json.Marshal(struct{}{})
 			initialPos = arg.Pos()

diff --git a/testdata/src/tests/tests.go b/testdata/src/tests/tests.go
@@ -468,3 +468,8 @@ func nonStructArgument() {
 	custom.Marshal(0)
 	custom.Unmarshal(nil, &[]int{})
 }
+
+// test for panic with nil object issue: https://github.com/junk1tm/musttag/issues/20
+func nilObject() {
+	json.Marshal(nil)
+}