Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorCollector.checkThrows() #1305

Closed
wants to merge 1 commit into from

Conversation

kcooney
Copy link
Member

@kcooney kcooney commented May 24, 2016

No description provided.

@marcphilipp
Copy link
Member

Nice! 👍

I think it might be helpful if checkThrows returned the (expected) exception, like Assert.expectThrows() does. More detailed checks could then be performed using ErrorCollector.checkThat(). What do you think?

@kcooney
Copy link
Member Author

kcooney commented May 24, 2016

@marcphilipp What would it return if the lambda did not throw that exception?

@marcphilipp
Copy link
Member

Point taken.

@marcphilipp
Copy link
Member

LGTM! Feel free to merge (and add it to the release notes). 😄

@kcooney kcooney closed this in b8b21a2 May 29, 2016
@kcooney kcooney deleted the check-throws branch May 29, 2016 16:24
@kcooney
Copy link
Member Author

kcooney commented May 29, 2016

Merged and added to the release notes

@marcphilipp
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants