-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StopWatch does not need to be Abstract #1110
Comments
@kcooney |
I don't have any objections. BTW, is there a reason why you needed a quick response? You created this issue less than a day ago |
Is there a usecase when it's not necessary to extend this class? |
We can commit in 4.13, no hurry; but usully you are fast to response so it looked like you did forget this. |
If measuring exec time, I don't need other notifications, only reading the runtime. |
@Tibor17 although we often respond to issues quickly, we all have day jobs :-) If we don't respond to issues within a few weeks, feel free to ping the issues. |
I forgot about runtime being public, never mind. No objections from me either. |
The PR #1111 was created. |
The StopWatch is abstract without any abstract method. I am forced to extend this class even if not necessary.
Can we remove the modifier?
The text was updated successfully, but these errors were encountered: