-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone number sharing api #49
Conversation
This is not to the lib but to the app to ignore the InvalidFragmentVersionForActivityResult lint error
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thank you! 🚀 🚀 🚀 I'll take a closer look soon. |
I've verified that adding the App compat addition is only to fix one of the warnings from sonar which is not a bug but a misconfigured version. (https://stackoverflow.com/a/66740530). The app works the exact same way even without adding the dependency. It would be easier if we can merge these changes, then split the whole code into a few modules
|
Closing since it seems no one wants to merge this. |
These first 2 screen shots show how the dialog pops up and use can choose to select their verified phone numbers.
Fix the country code selector to auto-change to autofilled phone number
Instead of filling just the
PhoneNumberNation
, the changes would auto-populate the country code from the filled numberSee screenshot1 and 2 for reference where original selected country was India but the autofill populated a number starting +1-858 ... which changed the country code to +1 (US)
If the user dismisses the first bottomsheet, then a regular keyboard with autofill is triggered. (Screenshot3)
which also suggests an autofill number (this was the original implementation)
Selecting this number also leads to the same result on screenshot2 which autofills the phone number as well as country code.
Followup:
as you type number's
country code parsing.