Skip to content

Commit

Permalink
common: Add Istio v1.16.0 manifests (kubeflow#2327)
Browse files Browse the repository at this point in the history
* common: Add Istio v1.16.0 manifests

Signed-off-by: Apostolos Gerakaris <[email protected]>

* Update kustomization file in example to deploy istio-1-16

Signed-off-by: Apostolos Gerakaris <[email protected]>

* tests: Update install Istio GH action script

Use Istio 1.16 for testing

Signed-off-by: Apostolos Gerakaris <[email protected]>

* common: Remove PodDisruptionBudget resources for Istio

Istio 1.6.0 generated manifests include some policy/v1
PodDisruptionBudget resources that we need to remove. See:
- istio/istio#12602
- istio/istio#24000

The current manifests utilize two "delete" patches:
- common/istio-1-16/istio-install/base/patches/remove-pdb.yaml
- common/istio-1-16/cluster-local-gateway/base/patches/remove-pdb.yaml

However these patches do not work with kustomize v3.2.0. The root
cause is that v3.2.0 doesn't have the appropriate openapi schema for
the policy/v1 API version resources. This is fixed in kustomize v4+.
See:
- kubernetes-sigs/kustomize#3694 (comment)
- kubernetes-sigs/kustomize#4495

Changes:
- We disable the delete patches until we upgrade to kustomize v4+.
  - tracked in: kubeflow#1797

- As a temporary workaraound we remove PodDisruptionBudget resources
  manually with yq before deploying Istio manifests.

- Update README file with instructions.

Refs: kubeflow#2325

Signed-off-by: Apostolos Gerakaris <[email protected]>

* Update README

Use the --cluster-specific flag when generating Istio 1.16 manifests
for K8s-1.25. See:
* istio/istio#41220

Signed-off-by: Apostolos Gerakaris <[email protected]>

* tests: Update GH Action workflows

Trigger the workflows when the Istio version changes

Signed-off-by: Apostolos Gerakaris <[email protected]>

Signed-off-by: Apostolos Gerakaris <[email protected]>
  • Loading branch information
apo-ger authored and kevin85421 committed Feb 28, 2023
1 parent 623fba4 commit e238b49
Show file tree
Hide file tree
Showing 39 changed files with 2,903 additions and 2,746 deletions.
1 change: 1 addition & 0 deletions .github/workflows/centraldb_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/centraldashboard/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/dex_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- common/dex/base/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/jwa_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ on:
pull_request:
paths:
- apps/jupyter/jupyter-web-app/upstream/**
<<<<<<< HEAD
- tests/gh-actions/kind-cluster.yaml
=======
- tests/gh-actions/install_istio.sh
>>>>>>> tests: Update GH Action workflows

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/nb_controller_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/jupyter/notebook-controller/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pipeline_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/pipeline/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/poddefaults_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/admission-webhook/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/profiles_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/profiles/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tb_controller_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/tensorboard/tensorboard-controller/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/train_operator_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/training-operator/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/twa_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ on:
pull_request:
paths:
- apps/tensorboard/tensorboards-web-app/upstream/**
<<<<<<< HEAD
- tests/gh-actions/kind-cluster.yaml
=======
- tests/gh-actions/install_istio.sh
>>>>>>> tests: Update GH Action workflows

jobs:
build:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/vwa_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths:
- apps/volumes-web-app/upstream/**
- tests/gh-actions/kind-cluster.yaml
- tests/gh-actions/install_istio.sh

jobs:
build:
Expand Down
Loading

0 comments on commit e238b49

Please sign in to comment.