Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: little change about how log_file, log_pos works, improve readability of comment in BinLogStreamReader __init__() #513

Open
jaehyeonpy opened this issue Oct 10, 2023 · 0 comments

Comments

@jaehyeonpy
Copy link
Contributor

jaehyeonpy commented Oct 10, 2023

In BinLogStreamReader init(), if log_file is specified by a user (which is not None), log_pos is not specified (which is None), __connect_to_stream() starts to send binlog events from the latest binlog file, not from the specified binlog file.

I want to modify __connect_to_stream() to send events from the specified binlog file, not events from the latest binlog file.


I also want to improve readability of comment about some init() parameters: log_file, log_pos, resume_stream, and skip_to_timestamp, auto_position, is_mariadb.

for skip_to_timestamp, auto_position, is_mariadb: if skip_to_timestamp as true, but is_mariadb as true or auto_position as true, then skip_to_timesatmp does not work. skip_to_timestamp only works if skip_to_timestamp as true, auto_position as false, is_mariadb as false. users may expect skip_to_timestamp to work after only giving skip_to_timestamp True, actually it does not though.

for log_file and log_pos, for instance, about the same as the #1 case, users may expect __connect_to_stream() to send events from the latest binlog file, because they specified the binlog file, actually it does not though.


the #2 would be fine, but the #1 may affect users. so I opened this issue before submitting pull request.

@jaehyeonpy jaehyeonpy changed the title suggestion: little change how log_file, log_pos works, improve readability of comment in BinLogStreamReader __init__() suggestion: little change about how log_file, log_pos works, improve readability of comment in BinLogStreamReader __init__() Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants