Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error when in non-strict mode and slideUp/slideDown redirects are involved #761

Closed
futpib opened this issue Mar 16, 2017 · 6 comments

Comments

@futpib
Copy link

futpib commented Mar 16, 2017

Originally reproduced in IE9, though I expect it to reproduce wherever strict mode is not supported.

Steps to reproduce

  1. Run in no-strict-mode environment
  2. Velocity.Promise is set to a Promise A+ implementation
  3. Code:
const element = document.createElement('div');
Velocity(element, 'slideDown').then(function () {
	console.log('resolved');
}, function (e) {
	console.log('rejected', e);
});

Expected

Prints 'resolved' (or 'rejected' if something went wrong)

Actual

Prints (in IE9)

Velocity: First argument ([object HTMLDivElement]) was not a property map, a known action, or a registered redirect. Aborting.

Debugging thoughts

@Rycochet
Copy link
Collaborator

Rycochet commented Mar 16, 2017

I've got a strong feeling that's (supposed to have) been fixed in the latest release - can you just check what version of Velocity you're running against?

@futpib
Copy link
Author

futpib commented Mar 16, 2017

1.4.3, latest available on npm. Should I check against master?

@futpib
Copy link
Author

futpib commented Mar 16, 2017

Also #757 is somewhat related (the Type.isWrapped(windows) part of this issue)

@Rycochet
Copy link
Collaborator

@futpib Nope, that's cool - they're currently the same - drat, looks like I need to spend more time on IE9 too - hoping to get some time to look at the various obsolete IE issues over the weekend...

@futpib
Copy link
Author

futpib commented Mar 16, 2017

Just checked that #757 fixes this indeed.

@futpib
Copy link
Author

futpib commented Mar 16, 2017

I guess this had nothing to do with promise rejection propagation

@futpib futpib changed the title Promise rejections are not propogated when in non-strict mode and slideUp/slideDown redirects are involved Unexpected error when in non-strict mode and slideUp/slideDown redirects are involved Mar 16, 2017
@futpib futpib closed this as completed Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants