background-color should be valid input

[intentionally-left-nil]

Repro is trivial: Just try to queue up a velocity animation to change the background-color to #000. It will fail. However, passing in backgroundColor succeeds.

Most of the code is set up to allow animating both background-color and backgroundColor but a small section of code in the start handler is missing this normalization code. This causes the code to fail to append the Red, Green and Blue styles. This cascades as a problem in Css.Values.getUnitType which now defaults to px because it fails the following regex below:

getUnitType: function (property) {
                if (/^(rotate|skew)/i.test(property)) {
                    return "deg";
                } else if (/(^(scale|scaleX|scaleY|scaleZ|alpha|flexGrow|flexHeight|zIndex|fontWeight)$)|((opacity|red|green|blue|alpha)$)/i.test(property)) {
                    /* The above properties are unitless. */
                    return "";
                } else {
                    /* Default to px for all other properties. */
                    return "px";
                }
            },

The fix is to add CSS.Names.camelCase somewhere to the init codepath. I have created a motivating PR here to better describe the issue.

Thanks!

[Rycochet]

I think this sort of thing should be checked globally - follow Angular2's example and accept either version in all places it can happen (this is a good case for unit tests) ;-)

[Rycochet]

Fixed by 5b7ec85 - all property values are camelCase before playing with them now.

[intentionally-left-nil]

Thank you!!! 🎉 🎊 🎉 🌮