Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "always" callback #126

Closed
Rycochet opened this issue Jun 26, 2014 · 4 comments
Closed

Add an "always" callback #126

Rycochet opened this issue Jun 26, 2014 · 4 comments

Comments

@Rycochet
Copy link
Collaborator

Currently the "complete" option doesn't fire if the animation is stopped for whatever reason - having an "always" gives the ability to run a function even if you cancel the animation early.

@julianshapiro julianshapiro changed the title Add "always:function()" option Feature: Add an "always" callback Jun 26, 2014
@julianshapiro julianshapiro changed the title Feature: Add an "always" callback Add an "always" callback Jun 26, 2014
@julianshapiro
Copy link
Owner

What if always was a boolean value? If true, fire complete even if the animation stops.

Would this be a cleaner solution than having two competing callback options (both complete and always). Thoughts?

@Rycochet
Copy link
Collaborator Author

Rycochet commented Jul 8, 2014

I think that the Promises support in #143 covers this nicely - so unless you want to add a specific callback I'd say close this :-)

@julianshapiro
Copy link
Owner

Having a promise returned necessitates using the utility function, and so always still has a purpose (although certainly a lesser one).

I'll leave this thread open to see who else comes by and asks for this. Thanks for everything, Robin.

@julianshapiro julianshapiro changed the title Add an "always" callback Deferred: Add an "always" callback Jul 8, 2014
@julianshapiro julianshapiro changed the title Deferred: Add an "always" callback Add an "always" callback Jul 13, 2014
@julianshapiro
Copy link
Owner

I'll close this for now. We'll see if anyone else requests this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants