slideUp/Down Sequences v2.0 #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the bug with broken animation with diff box models
julianshapiro
changed the title
julianshapiro
changed the title
Rycochet
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixes slideUp/Down behavior with box-sizing:border-box. Closes #121. Thank you, @legomushroom. Fixed issue where couldn’t get height/width values on an element set to display:none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request consist of 3 commits.
border-boxbox model.they 3 close #96 but I'd like to make more improvements in the future. For instance systemize all 'show' and 'hide' animations(fadeIn, fadeDown, slideIn, slideDown etc) like jquery does it, so codebase will be dry.
More about 1 - 703c07e
Basically sequences are created first and then we have an ability to check if particular sequence is needed (in the begin callback), so I'm setting isSkipped flag on the element and then at the tick() I'm completeCall() -ing it relying on this flag. It adds below 0.008ms more CPU time for flag checks for every element in the Velocity.State.calls loop and as for me could not be considered as perf overhead. My concern is the place where isSkipped flag is set(right on the element itself), but without access to the tween I don't see better one now :)