Skip to content
This repository has been archived by the owner on Aug 31, 2020. It is now read-only.

Restore Windows installer #131

Closed
3 tasks
pktiuk opened this issue Jun 26, 2020 · 8 comments
Closed
3 tasks

Restore Windows installer #131

pktiuk opened this issue Jun 26, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pktiuk
Copy link
Contributor

pktiuk commented Jun 26, 2020

This project requires installer for Windows.

Original antimicro was compiled on Windows, but this fork doesn't have this feature yet.
Most of required components are already included in antimicro's repository.

It would be nice to also add portable version of AntiMicroX, it was done there

Things to do:

  • compile AntimicroX on Windows
  • Add build instructions to README
  • Add building and uploading exe to github actions on release
@pktiuk pktiuk mentioned this issue Jun 26, 2020
7 tasks
@juliagoda
Copy link
Owner

It could be awesome, but I don't have Windows and to do that, you would need to create additional classes in project, that base on C++ and C too. You can't achieve this, only adding changes to CMakeLists. I noticed, that Github Sponsor has been around for Poland too for a while and I have to take a look at this.

@juliagoda juliagoda added enhancement New feature or request good first issue Good for newcomers labels Jun 26, 2020
@pktiuk
Copy link
Contributor Author

pktiuk commented Jun 28, 2020

I have copied missing files and CMakeLists configs from antimicro, but currently I have some problems with finding QT libraries by cmake.
In case if someone more familiarized with Windows would like to try this porting I have published my changes here: https://github.com/pktiuk/antimicroX/tree/windows_compilation

@juliagoda juliagoda pinned this issue Jun 28, 2020
@AliAsiri20
Copy link

Thank you pktiuk, You are an awesome guy.
I have copied more lines from the old CmakeLIsts for the QT libraries, and I was able to run cmake without errors, but when I try to build the .exe file following the instructions on the old Antimicro page. I get 6 errors related to UTF-8 unicode I think. I'll leave it for someone who knows what is he doing.
I just want to say thank you.

@rayman3003
Copy link

Can we have a windows build?

Or antimicroX is an exclusive linux app?

@juliagoda
Copy link
Owner

Can we have a windows build?

Could your read the posts above? Thank you

@rayman3003
Copy link

I don't have Windows

https://www.virtualbox.org/wiki/Linux_Downloads

@pktiuk
Copy link
Contributor Author

pktiuk commented Jul 3, 2020

@juliagoda
We should also add tag "help wanted"

@rayman3003
Installing Windows takes a lot of time to set up everything correctly (it takes much more time to install dependencies and apps than in Linux, where we can download everything we need using one simple command).
Moreover, this task would be more suitable for a developer familiar with Windows, it's workflow and dependency management, so for this task, we need someone who is familiar with Windows and it's tools because he has to not only compile it but also create automated script installing dependencies and building binaries after every release.

@juliagoda juliagoda added the help wanted Extra attention is needed label Jul 3, 2020
@pktiuk pktiuk changed the title Windows installer Restore Windows installer Jul 6, 2020
@juliagoda juliagoda unpinned this issue Aug 24, 2020
@pktiuk
Copy link
Contributor Author

pktiuk commented Aug 26, 2020

Due to ending maintenance of AntiMicroX on this repository this issue is moved to a new repository and will and can be further tracked here: AntiMicroX/antimicrox#4

@pktiuk pktiuk closed this as completed Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants