Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultStorage Performance Optimization: reduce/reuse Salsa traces #20

Closed
ghost opened this issue Jun 4, 2020 · 1 comment
Closed

DefaultStorage Performance Optimization: reduce/reuse Salsa traces #20

ghost opened this issue Jun 4, 2020 · 1 comment
Labels
performance CPU, RAM, disk utilization and efficiency

Comments

@ghost
Copy link

ghost commented Jun 4, 2020

(We already recycle 😛)

Two separate, but related, potential performance optimizations:

https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/default_storage.jl#L182-L193

https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/default_storage.jl#L221-L229
@ghost ghost added the performance CPU, RAM, disk utilization and efficiency label Jun 4, 2020
@ghost ghost mentioned this issue Jun 4, 2020
Merged
@NHDaly NHDaly mentioned this issue Jul 4, 2020
Merged
@NHDaly
Copy link
Collaborator

NHDaly commented Jul 13, 2020

Fixed in #27

@NHDaly NHDaly closed this as completed Jul 13, 2020
@NHDaly NHDaly assigned NHDaly and unassigned NHDaly Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance CPU, RAM, disk utilization and efficiency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NHDaly