Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace/configuration sends out-of-spec message #418

Closed
non-Jedi opened this issue Nov 11, 2019 · 3 comments
Closed

workspace/configuration sends out-of-spec message #418

non-Jedi opened this issue Nov 11, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@non-Jedi
Copy link
Member

non-Jedi commented Nov 11, 2019

Per discussion in #374, the language server sends:

[ Info: SENT: {"method":"workspace/configuration","id":-100,"params":{"items":[{"scopeUri":null,"section":"julia.format.indent"},{"scopeUri":null,"section":"julia.format.indents"},{"scopeUri":null,"section":"julia.format.ops"},{"scopeUri":null,"section":"julia.format.tuples"},{"scopeUri":null,"section":"julia.format.curly"},{"scopeUri":null,"section":"julia.format.calls"},{"scopeUri":null,"section":"julia.format.iterOps"},{"scopeUri":null,"section":"julia.format.comments"},{"scopeUri":null,"section":"julia.format.docs"},{"scopeUri":null,"section":"julia.format.lineends"}]},"jsonrpc":"2.0"}

and the scopeUri field cannot be null.

@davidanthoff davidanthoff added this to the v0.7.0 milestone Nov 14, 2019
@davidanthoff
Copy link
Member

So I took another look at

macro json_read(arg)
, and the more I stare at that, it probably only solves the problem when we read a JSON string into a Julia structure, but not when we serialize a Julia structure into a JSON string...

I just pushed another commit to https://github.com/julia-vscode/LanguageServer.jl/pull/416/files that hopefully also fixes the write story. Could you try that branch again?

@davidanthoff
Copy link
Member

@non-Jedi did you have a chance to test whether #416 fixes this for you?

@non-Jedi
Copy link
Member Author

I haven't yet. Will get to in next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants