Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce mechanism for error annotations #87

Open
Keno opened this issue Nov 22, 2018 · 2 comments
Open

Reintroduce mechanism for error annotations #87

Keno opened this issue Nov 22, 2018 · 2 comments

Comments

@Keno
Copy link
Collaborator

Keno commented Nov 22, 2018

We seem to have lost the capability to have the parser emit error annotations. That's a shame, because they were quite nice (e.g. in FancyDiagnostics). What would be the best way to add back that capability?

@ZacLN
Copy link
Contributor

ZacLN commented Nov 22, 2018

Can you use ParseState.errors? and possibly modify the Error to hold a type indicator field?

@Keno
Copy link
Collaborator Author

Keno commented Nov 22, 2018

so what we want to do is have some place to store extra warning messages for every error (maybe just add an annotations array to the error type), emitting those when we unwind the stack after an error.

@davidanthoff davidanthoff added this to the Backlog milestone Jun 12, 2019
@davidanthoff davidanthoff removed this from the Backlog milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants