-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor client_facades and specified_facades shape #1155
Conversation
Thanks, I think it would be good to do something like this in future -- or even better, do away with the manually specified |
reopening and moving back to draft; I'll rebase and update this after #1150 |
Closing was probably premature, sorry. I'd still prefer if we held off on merging this till we finish with #1099. I know the changes in python-libjuju are pretty minor, but I've been using the current All doable to fix, of course, but probably not worth having to fix -- unless this change simplifies work for you? |
totally fine to sit on this. |
607f28f
to
8d3cad1
Compare
@james-garner-canonical rebased and updated the test, it's ready for review. |
31baac1
to
b96cc1c
Compare
/merge |
b96cc1c
to
dfeb7fc
Compare
/merge |
1 similar comment
/merge |
Description
Streamlining facades code:
specified_facades
argument as it's