Skip to content

Commit

Permalink
Merge pull request #1113 from james-garner-canonical/client-schema-1-…
Browse files Browse the repository at this point in the history
…remove-eol-schema

#1113

Remove `3.2.X` schemas. Delete `_client*.py` and run `make client`.

#### Description

Moving towards the goal of having schemas and generated code in python-libjuju only for the latest supported Juju versions (`3.1.9`, `3.3.6`, `3.5.4`, `3.5.3`), and using client only schemas (see #1099), this PR removes schemas for EOL Juju 3.2, and reruns code generations, removing `_client*.py` files and then running `make client`.


#### QA Steps

CI steps should all continue to pass, except for integration testing which should continue to fail with the usual suspects (see #1108 for a non-exhaustive table of tests that sometimes fail on `main`). 


#### Notes

To hopefully simplify the diffs, this is the first PR in a planned sequence of PRs that will depend on each other. Subsequent PRs will be:
1. replace current schemas with latest release client only schemas (`3.1.9`, `3.3.6`) and regenerate code
2. add client only schema for `3.4.5` and regenerate code
3. add client only schema for `3.5.3` and regenerate code
  • Loading branch information
jujubot authored Sep 27, 2024
2 parents bcbce1e + 7eb547c commit 0a22648
Show file tree
Hide file tree
Showing 9 changed files with 80 additions and 119,431 deletions.
4,508 changes: 0 additions & 4,508 deletions juju/client/_client12.py

This file was deleted.

4,451 changes: 0 additions & 4,451 deletions juju/client/_client13.py

This file was deleted.

1,922 changes: 0 additions & 1,922 deletions juju/client/_client14.py

This file was deleted.

1,786 changes: 0 additions & 1,786 deletions juju/client/_client15.py

This file was deleted.

1,679 changes: 0 additions & 1,679 deletions juju/client/_client16.py

This file was deleted.

151 changes: 80 additions & 71 deletions juju/client/_client18.py

Large diffs are not rendered by default.

742 changes: 0 additions & 742 deletions juju/client/_client8.py

This file was deleted.

52,049 changes: 0 additions & 52,049 deletions juju/client/schemas-juju-3.2.0.json

This file was deleted.

52,223 changes: 0 additions & 52,223 deletions juju/client/schemas-juju-3.2.3.json

This file was deleted.

0 comments on commit 0a22648

Please sign in to comment.