binaryen.js is no longer bundled in binaryen

[kripken]

And emscripten doesn't need it anyhow (it's for handwritten js users).

This binaryen change broke tagged version building,

http://ec2-54-213-252-128.us-west-2.compute.amazonaws.com:8112/#/builders/5/builds/193

Hopefully this will fix it, although I'm unsure how the bots receive updates to the emsdk script - @juj, do you know?

[juj]

Looks good.

The bots automatically update emsdk as part of their build steps.

See step 1 "Update" on the page you linked. On the right hand side you see that step is calling update_emslave.bash script, which is https://github.com/juj/emslave/blob/master/bin/update_emslave.bash, and that does updating emsdk to latest: https://github.com/juj/emslave/blob/master/bin/update_emslave.bash#L36 . So the next time the builds are kicked off it should be getting the updated emsdk version.

[kripken]

Thanks @juj, sounds good!

@asria - that is a related issue, caused by the change that made this fix necessary. It should be fixed already on incoming, see emscripten-core/emscripten#6815

[trzecieu]

Hmm... This has created a situation, where the newest emsdk doesn't work with the last tag of emscripten (or one of recent, if new tag will be added) so basically 1.38.7 is broken

[kripken]

@asria yeah, sorry for the breakage - we need to tag a new version to fix this. I'm working on that now.

[trzecieu]

No worries at all. These projects are awesome, and you are doing outstanding work. If some help is needed with releases I might help.

[trzecieu]

After some reflections, this change actually makes impossible to use every version of emscripten what's currently tagged.
Maybe let's make it opt-in somehow? Or keep current logic for compatibility reason (what's a technical dept unfortunately)

[kripken]

Looks like 1.38.7 built ok on the bots on ubuntu and windows so far, os x still working. So I think we are ok now?

Regarding helping - testing builds and notifying about any issues is very helpful, thanks @asria!

[kripken]

Oh wait, we aren't ok yet, as the emscripten fix for this issue landed after 1.38.7. I'll tag 1.38.8 now.

[kripken]

Tagged 1.38.8, hopefully after that all is good.

[trzecieu]

1.38.8 is stable 👍

[kripken]

Great, thanks for confirming!