mount: recovery read only file handler #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4524 +/- ##
===========================================
- Coverage 55.65% 24.22% -31.43%
===========================================
Files 157 24 -133
Lines 42593 16348 -26245
===========================================
- Hits 23704 3960 -19744
+ Misses 16253 11911 -4342
+ Partials 2636 477 -2159 ☔ View full report in Codecov by Sentry. |
zhijian-pro
force-pushed
the
recovery-readonly-fh
branch
from
ad3f8f5
to
35b1f9d
Compare
zhijian-pro
commented
Mar 15, 2024
davies
reviewed
Mar 19, 2024
davies
reviewed
Mar 20, 2024
pkg/vfs/vfs.go
Outdated
|
|
||
| // there could be read operation for write-only if kernel writeback is enabled | ||
| if !v.Conf.FuseOpts.EnableWriteback && !hasReadPerm(h.flags) { | ||
| err = syscall.EACCES |
There was a problem hiding this comment.
EBADF fd is not a valid file descriptor or is not open for reading.
davies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4504