Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: fix temporary name when create a file #4215

Merged
merged 2 commits into from
Nov 30, 2023
Merged

sync: fix temporary name when create a file #4215

merged 2 commits into from
Nov 30, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Nov 29, 2023

This PR also fixed a but that may leak temporary file when Create() returns an error but the file is created.

close #4212

@davies davies requested a review from SandyXSD November 29, 2023 14:59
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9a40759) 55.57% compared to head (ddd310f) 54.13%.
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/object/file.go 70.00% 2 Missing and 1 partial ⚠️
pkg/object/nfs.go 72.72% 2 Missing and 1 partial ⚠️
pkg/object/sftp.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4215      +/-   ##
==========================================
- Coverage   55.57%   54.13%   -1.44%     
==========================================
  Files         154      121      -33     
  Lines       39492    31127    -8365     
==========================================
- Hits        21949    16852    -5097     
+ Misses      15085    12266    -2819     
+ Partials     2458     2009     -449     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 984bf0d into main Nov 30, 2023
34 of 39 checks passed
@davies davies deleted the fix_tmp_name branch November 30, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

juicefs sync fail:file name too long
2 participants