Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1: Progress Bar #3

Merged
merged 3 commits into from
May 12, 2021

Conversation

wise-introvert
Copy link
Contributor

  • Added progress bar using ora

close #1

@jugshaurya
Copy link
Owner

jugshaurya commented May 12, 2021

@wise-introvert, I appreciated this addition, but I was actually planning to add a progress bar that shows the user the percentage of videos already merged. Like 0%, 20%, 40%, 60% , 100%.

Feel free to add that, will be merging this as well. I think this is also a good way to show the user the progress, but will not be closing the issue yet.

@wise-introvert
Copy link
Contributor Author

@jugshaurya my bad, man!

@jugshaurya jugshaurya merged commit 7e92639 into jugshaurya:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] Add a progress bar while the videos are merging
2 participants