Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Remove some whitespace around the Unified Histogram resize button #5

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[Discover] Remove some whitespace around the Unified Histogram resize button #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/unified_histogram/public/layout/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ export const UnifiedHistogramLayout = ({
chart={chart}
breakdown={breakdown}
appendHitsCounter={appendHitsCounter}
appendHistogram={showFixedPanels ? <EuiSpacer size="s" /> : <EuiSpacer size="l" />}
appendHistogram={<EuiSpacer size="s" />}
disableAutoFetching={disableAutoFetching}
disableTriggers={disableTriggers}
disabledActions={disabledActions}
Expand Down
15 changes: 2 additions & 13 deletions src/plugins/unified_histogram/public/panels/panels_resizable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,7 @@
* Side Public License, v 1.
*/

import {
EuiResizableContainer,
useEuiTheme,
useGeneratedHtmlId,
useResizeObserver,
} from '@elastic/eui';
import { EuiResizableContainer, useGeneratedHtmlId, useResizeObserver } from '@elastic/eui';
import type { ResizeTrigger } from '@elastic/eui/src/components/resizable_container/types';
import { css } from '@emotion/react';
import { isEqual, round } from 'lodash';
Expand Down Expand Up @@ -162,12 +157,6 @@ export const PanelsResizable = ({
disableResizeWithPortalsHack();
}, [disableResizeWithPortalsHack, resizeWithPortalsHackIsResizing]);

const { euiTheme } = useEuiTheme();
const buttonCss = css`
margin-top: -${euiTheme.size.base};
margin-bottom: 0;
`;

return (
<EuiResizableContainer
className={className}
Expand All @@ -189,7 +178,7 @@ export const PanelsResizable = ({
{topPanel}
</EuiResizablePanel>
<EuiResizableButton
css={[resizeWithPortalsHackButtonCss, buttonCss]}
css={resizeWithPortalsHackButtonCss}
data-test-subj="unifiedHistogramResizableButton"
/>
<EuiResizablePanel
Expand Down
Loading