Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clash of component names #9

Open
vostramedia opened this issue Jun 9, 2017 · 1 comment
Open

Clash of component names #9

vostramedia opened this issue Jun 9, 2017 · 1 comment
Assignees

Comments

@vostramedia
Copy link

vostramedia commented Jun 9, 2017

This package will cause issues with other packages as it makes use of similar component names.

For example the component <Row> will clash with the component <Row> from react-material-responsive-grid.

Also the <Table> component will clash with the default material-ui component also called <Table>

If you want to use all of these in conjunction it will not work.

@jtassin jtassin self-assigned this Jun 17, 2017
@jtassin
Copy link
Owner

jtassin commented Jun 17, 2017

Hi @vostramedia.
Thanks for your feedback.

To avoid this problem, you should alias your imports.
Like this :

import { Row as ReactResponsiveTableRow } from 'react-responsive-table';

And use it with your alias

<ReactResponsiveTableRow  ... />

It would be a too important breaking change to change Row/Table and Cell to something else.
I keep the issue openned to add it to the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants