Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

Commenting feature #42

Open
jtanadi opened this issue Apr 2, 2020 · 1 comment
Open

Commenting feature #42

jtanadi opened this issue Apr 2, 2020 · 1 comment
Labels
backend Server-side issues, incl. sockets, etc. enhancement New feature or request frontend Client-side issues question Further information is requested

Comments

@jtanadi
Copy link
Owner

jtanadi commented Apr 2, 2020

Add feature for users to add comments per page.

Because the app doesn't allow PDF files to be downloaded, the comments don't have to be inserted into the PDF (ie. they can be temporary, and only show up for the duration of the meeting). In application, comments would probably end up as short reminders, for example, "Go back to this page at the end of presentation."

Some thoughts:

  1. Don't store comments on the server and rely on each user's localstorage. Once a user posts a comment, the socket will broadcast to other users in the room, and each would store that PDF's comments locally.
    • In reality, the server would need to at least cache comments in memory, because otherwise what happens when a user joins halfway through a meeting?
  2. Provision a database to temporarily store comments for each PDF. All comments for that PDF will be downloaded at the end of each session and have specific TTLs (like S3 objects).
    • We may already need to provision a database to keep track of users if we implement authentication, so adding another model may not be so bad.
@jtanadi jtanadi added backend Server-side issues, incl. sockets, etc. enhancement New feature or request frontend Client-side issues question Further information is requested labels Apr 2, 2020
@jtanadi
Copy link
Owner Author

jtanadi commented Apr 22, 2020

pdf-lib will allow us to insert text into an existing PDF.

conveyor would need to also upload the PDF to the s3 bucket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Server-side issues, incl. sockets, etc. enhancement New feature or request frontend Client-side issues question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant