Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prop value with an expression type of SequenceExpression could not be resolved. Please file issue to get this fixed immediately. #95

Closed
chenlulouis opened this issue Apr 22, 2020 · 3 comments · Fixed by intuit/design-systems-cli#656

Comments

@chenlulouis
Copy link

Hi there,
Looks like there is missing type regarding SequenceExpression, resulting in a error output.
could you please add it to fix the error? TKS!
var TYPES = {
Identifier: _Identifier2.default,
Literal: _Literal2.default,
JSXElement: _JSXElement2.default,
TaggedTemplateExpression: _TaggedTemplateExpression2.default,
TemplateLiteral: _TemplateLiteral2.default,
ArrowFunctionExpression: _FunctionExpression2.default,
FunctionExpression: _FunctionExpression2.default,
LogicalExpression: _LogicalExpression2.default,
MemberExpression: _MemberExpression2.default,
OptionalMemberExpression: _OptionalMemberExpression2.default,
CallExpression: _CallExpression2.default,
UnaryExpression: _UnaryExpression2.default,
ThisExpression: _ThisExpression2.default,
ConditionalExpression: _ConditionalExpression2.default,
BinaryExpression: _BinaryExpression2.default,
ObjectExpression: _ObjectExpression2.default,
NewExpression: _NewExpression2.default,
UpdateExpression: _UpdateExpression2.default,
ArrayExpression: _ArrayExpression2.default,
BindExpression: _BindExpression2.default,
SpreadElement: _SpreadElement2.default,
TypeCastExpression: _TypeCastExpression2.default
};

@ljharb
Copy link
Member

ljharb commented Apr 22, 2020

A PR would be welcome.

@ShubhankarKG
Copy link

Hey @ljharb , I am new here. If you could guide me, that would be great. I'd like to get started here by contributing :)

@ljharb
Copy link
Member

ljharb commented Jul 25, 2020

@ShubhankarKG take a look at https://github.com/jsx-eslint/jsx-ast-utils/tree/master/src/values/expressions - i think you'd need to add a SequenceExpression file, and then import it into https://github.com/jsx-eslint/jsx-ast-utils/blob/master/src/values/expressions/index.js. Before doing any of that tho, I'd suggest adding tests somewhere in https://github.com/jsx-eslint/jsx-ast-utils/tree/master/__tests__/src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants