[New] Add suggestions to no-unescaped-entities
#3831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
==========================================
- Coverage 97.73% 97.67% -0.06%
==========================================
Files 133 136 +3
Lines 9917 9938 +21
Branches 3678 3679 +1
==========================================
+ Hits 9692 9707 +15
- Misses 225 231 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks pretty good, please mark ready for review once tests are passing :-) |
|
@ljharb Thanks! 🙏 I have some issues running the tests locally Any help here would be greatly appreciated! |
|
You'll need to run the same commands the CI workflow is using to ensure the right versions of deps are installed; in this case i think it's that there's a lot of test cases that need to have |
|
Oh, that makes sense. Will try it, thanks! |
ljharb
force-pushed
the
feat/3277-no-unescaped-entities
branch
from
4d9d249
to
95297ed
Compare
##### [v7.37.0](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7370---20240926) ##### Added - add type generation ([#3830][] [@voxpelli](https://github.com/voxpelli)) - \[`no-unescaped-entities`]: add suggestions ([#3831][] [@StyleShit](https://github.com/StyleShit)) - \[`forbid-component-props`]: add `allowedForPatterns`/`disallowedForPatterns` options ([#3805][] [@Efimenko](https://github.com/Efimenko)) - \[`no-unstable-nested-components`]: add `propNamePattern` to support custom render prop naming conventions ([#3826][] [@danreeves](https://github.com/danreeves)) ##### Changed - \[readme] flat config example for react 17+ ([#3824][] [@GabenGar](https://github.com/GabenGar)) [7.36.2]: jsx-eslint/eslint-plugin-react@v7.36.1...v7.36.2 [#3831]: jsx-eslint/eslint-plugin-react#3831 [#3830]: jsx-eslint/eslint-plugin-react#3830 [#3826]: jsx-eslint/eslint-plugin-react#3826 [#3824]: jsx-eslint/eslint-plugin-react#3824 [#3805]: jsx-eslint/eslint-plugin-react#3805
### Why? Following up on #72752, the ESLint fix suggestion for `react/no-unescaped-entities` rule was added at jsx-eslint/eslint-plugin-react#3831, released on [v7.37.0](https://github.com/jsx-eslint/eslint-plugin-react/releases/tag/v7.37.0). Therefore, we bump the `eslint-plugin-react` version to `^7.37.0`.
Closes #3277