-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Support shorthand fragment syntax #1956
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e248365
Support shorthand fragments in Components
alexzherdev 6cf535a
`jsx-curly-brace-presence`: support shorthand fragments
alexzherdev 2165858
`jsx-curly-spacing`: support shorthand fragments
alexzherdev ac7f3f5
`jsx-filename-extension`: support shorthand fragments
alexzherdev d537c06
`jsx-max-depth`: support shorthand fragments
alexzherdev 83eb307
`jsx-one-expression-per-line`: support shorthand fragments
alexzherdev bace62c
`no-unescaped-entities`: support shorthand fragments
alexzherdev 2899e57
`jsx-wrap-multilines`: support shorthand fragments
alexzherdev 0a68c28
Test for #1694
alexzherdev 128b38f
`jsx-closing-tag-location`: support shorthand fragments
alexzherdev 18898e1
`jsx-uses-react`: support shorthand fragments
alexzherdev dd00d8a
`jsx-indent`: support shorthand fragments
alexzherdev 083adf8
`jsx-child-element-spacing`: support shorthand fragments
alexzherdev 3d0580f
`jsx-no-comment-textnodes`: add tests for shorthand fragments
alexzherdev c1b6da0
`jsx-no-literals`: add tests for shorthand fragments
alexzherdev 8215be3
Fix linting error
alexzherdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,10 @@ ruleTester.run('jsx-curly-brace-presence', rule, { | |
{ | ||
code: '<App {...props}>foo</App>' | ||
}, | ||
{ | ||
code: '<>foo</>', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This rule doesn't really care whether it's an element or a fragment, so I just added one simple valid test, and one invalid. |
||
parser: 'babel-eslint' | ||
}, | ||
{ | ||
code: '<App {...props}>foo</App>', | ||
options: [{props: 'never'}] | ||
|
@@ -259,6 +263,13 @@ ruleTester.run('jsx-curly-brace-presence', rule, { | |
options: [{children: 'never'}], | ||
errors: [{message: unnecessaryCurlyMessage}] | ||
}, | ||
{ | ||
code: '<>{`foo`}</>', | ||
output: '<>foo</>', | ||
parser: 'babel-eslint', | ||
options: [{children: 'never'}], | ||
errors: [{message: unnecessaryCurlyMessage}] | ||
}, | ||
{ | ||
code: `<MyComponent>{'foo'}</MyComponent>`, | ||
output: '<MyComponent>foo</MyComponent>', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for a better name welcome (
isJSXElementOrFragment
seemed too wordy)