Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prop-types not detected in async functions #1473

Closed
jseminck opened this issue Oct 12, 2017 · 2 comments
Closed

prop-types not detected in async functions #1473

jseminck opened this issue Oct 12, 2017 · 2 comments
Labels
bug help wanted

Comments

@jseminck
Copy link
Contributor

Encountered this while working on CodeSandbox.

When I stripped async from the function, then the prop-types rule started to complain about modalActions not being defined in the propTypes. When I re-added async, then the warning disappeared.

async_props
@ljharb
Copy link
Member

ljharb commented Oct 12, 2017

Presumably we're just not checking the node type for async arrow function expressions in a class property (probably not non-arrows either?).

@jseminck jseminck mentioned this issue Dec 6, 2017
Closed
@ThiefMaster ThiefMaster mentioned this issue Oct 16, 2018
Merged
@ljharb
Copy link
Member

ljharb commented Oct 16, 2018

Fixed in #1939.

@ljharb ljharb closed this as completed Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @jseminck