Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The deprecated rule label-has-for is still enabled in the strict preset #751

Closed
brianespinosa opened this issue Oct 9, 2020 · 1 comment · Fixed by #734
Closed

The deprecated rule label-has-for is still enabled in the strict preset #751

brianespinosa opened this issue Oct 9, 2020 · 1 comment · Fixed by #734

Comments

@brianespinosa
Copy link

The label-has-for rule has been deprecated. This rule was removed in the recommended preset, but it is still present in the strict preset. If this rule is in fact deprecated, we should also be removed from the strict preset.

The replacement rule label-has-associated-control is enabled in both the recommended and strict presets already.
@brianespinosa brianespinosa changed the title label-has-for is still enabled in the strict preset The deprecated rule label-has-for is still enabled in the strict preset Oct 9, 2020
@brianespinosa
Copy link
Author

Ah great! It looks like someone already opened a PR to resolve this: #734

@ljharb ljharb mentioned this issue Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn off label-has-for in strict rule set janmonschke/eslint-plugin-jsx-a11y
1 participant
@brianespinosa