libtldl: remove libltdl from the tree

The libltdl interface has been completely replaced by the OPAL DL
framework (i.e., the opal_dl interface).

Fixes open-mpi#311

autogen.pl

@@ -1,6 +1,6 @@
 #!/usr/bin/env perl
 #
-# Copyright (c) 2009-2014 Cisco Systems, Inc.  All rights reserved.
+# Copyright (c) 2009-2015 Cisco Systems, Inc.  All rights reserved.
 # Copyright (c) 2010      Oracle and/or its affiliates.  All rights reserved.
 # Copyright (c) 2013      Mellanox Technologies, Inc.
 #                         All rights reserved.
@@ -1265,7 +1265,6 @@ sub patch_autotools_output {
 verbose "==> Remove stale files\n";
 find_and_delete(qw/config.guess config.sub depcomp compile install-sh ltconfig
     ltmain.sh missing mkinstalldirs libtool/);
-system("rm -rf opal/libltdl");
 
 # Remove the old m4 file and write the new one
 verbose "==> Writing m4 file with autogen.pl results\n";
@@ -1292,26 +1291,6 @@ sub patch_autotools_output {
 
 #---------------------------------------------------------------------------
 
-# For FreeBSD (carried over from autogen.sh); apparently some versions
-# of automake don't so this (prior to 1.9.7...?).
-system("chmod u+w opal/libltdl/configure");
-
-#---------------------------------------------------------------------------
-
-++$step;
-verbose "\n$step. Patching autotools output on top-level tree :-(\n\n";
-
-# Patch preopen error in libltdl
-if (-f "opal/libltdl/loaders/preopen.c") {
-    verbose "=== Patching preopen error masking in libltdl\n";
-    safe_system("$patch_prog -N -p0 < config/libltdl-preopen-error.diff");
-    unlink("opal/libltdl/loaders/preopen.c.rej");
-}
-
-patch_autotools_output(".");
-
-#---------------------------------------------------------------------------
-
 verbose "
 ================================================
 Open MPI autogen: completed successfully.  w00t!

config/Makefile.am

@@ -9,7 +9,7 @@
 #                         University of Stuttgart.  All rights reserved.
 # Copyright (c) 2004-2005 The Regents of the University of California.
 #                         All rights reserved.
-# Copyright (c) 2006-2010 Cisco Systems, Inc.  All rights reserved.
+# Copyright (c) 2006-2015 Cisco Systems, Inc.  All rights reserved.
 # Copyright (c) 2010      Oracle and/or its affiliates.  All rights 
 #                         reserved.
 # Copyright (c) 2014      Intel, Inc. All rights reserved.
@@ -23,7 +23,6 @@
 EXTRA_DIST = \
         distscript.csh \
 	opal_get_version.m4sh \
-	libltdl-preopen-error.diff \
 	ltmain_pgi_tp.diff \
         opal_mca_priority_sort.pl
 

config/opal_configure_options.m4

@@ -10,7 +10,7 @@ dnl Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
 dnl                         University of Stuttgart.  All rights reserved.
 dnl Copyright (c) 2004-2005 The Regents of the University of California.
 dnl                         All rights reserved.
-dnl Copyright (c) 2006-2014 Cisco Systems, Inc.  All rights reserved.
+dnl Copyright (c) 2006-2015 Cisco Systems, Inc.  All rights reserved.
 dnl Copyright (c) 2007      Sun Microsystems, Inc.  All rights reserved.
 dnl Copyright (c) 2009      IBM Corporation.  All rights reserved.
 dnl Copyright (c) 2009      Los Alamos National Security, LLC.  All rights

configure.ac

@@ -1237,8 +1237,6 @@ fi
 # a C++ compiler.
 AS_IF([test "$OMPI_WANT_FORTRAN_BINDINGS" != "1"],[F77=no FC=no])
 
-LT_CONFIG_LTDL_DIR([opal/libltdl], [subproject])
-LTDL_CONVENIENCE
 LT_INIT([dlopen win32-dll])
 
 # What's the suffix of shared libraries?  Inspired by generated
@@ -1275,8 +1273,6 @@ esac
 AC_SUBST(OPAL_DYN_LIB_PREFIX)
 AC_SUBST(OPAL_DYN_LIB_SUFFIX)
 
-OPAL_SETUP_LIBLTDL
-
 # Need the libtool binary before the rpathify stuff
 LT_OUTPUT
 

contrib/nightly/reports/check_devel_headers.pl

@@ -10,6 +10,7 @@
 #                         University of Stuttgart.  All rights reserved.
 # Copyright (c) 2004-2005 The Regents of the University of California.
 #                         All rights reserved.
+# Copyright (c) 2015 Cisco Systems, Inc.  All rights reserved.
 # $COPYRIGHT$
 # 
 # Additional copyrights may follow
@@ -90,11 +91,6 @@ sub wanted {
     elsif ($parts[0] eq "ompi" && $parts[1] eq "mpi" && $parts[2] eq "f90") {
         return;
     }
-    # The only file we want in opal/libltdl is ltdl.h
-    elsif ($parts[0] eq "opal" && $parts[1] eq "libltdl" &&
-           $name ne "ltdl.h") {
-        return;
-    }
     # The only file we want in opal/event is event.h
     elsif ($parts[0] eq "opal" && $parts[1] eq "event" &&
            $name ne "event.h") {

opal/Makefile.am

@@ -9,7 +9,7 @@
 #                         University of Stuttgart.  All rights reserved.
 # Copyright (c) 2004-2005 The Regents of the University of California.
 #                         All rights reserved.
-# Copyright (c) 2009-2014 Cisco Systems, Inc.  All rights reserved.
+# Copyright (c) 2009-2015 Cisco Systems, Inc.  All rights reserved.
 # $COPYRIGHT$
 # 
 # Additional copyrights may follow
@@ -19,7 +19,6 @@
 
 SUBDIRS = \
 	include \
-        $(LIBLTDL_SUBDIR) \
 	asm \
         datatype \
         etc \
@@ -35,7 +34,6 @@ SUBDIRS = \
 # therefore make distclean will fail).
 DIST_SUBDIRS = \
 	include \
-	$(LIBLTDL_SUBDIR) \
 	asm \
         datatype \
         etc \
@@ -49,7 +47,6 @@ DIST_SUBDIRS = \
 lib_LTLIBRARIES = lib@[email protected]
 lib@OPAL_LIB_PREFIX@open_pal_la_SOURCES =
 lib@OPAL_LIB_PREFIX@open_pal_la_LIBADD = \
-        $(LIBLTDL) \
         asm/libasm.la \
         datatype/libdatatype.la \
         mca/base/libmca_base.la \
@@ -69,11 +66,6 @@ lib@OPAL_LIB_PREFIX@open_pal_la_SOURCES += $(headers)
 if WANT_INSTALL_HEADERS
 opaldir = $(opalincludedir)/$(subdir)
 nobase_opal_HEADERS = $(headers)
-
-# This is somewhat of a hack -- libltdl is installed by libtoolize,
-# and us installing the header here is slightly less kludgey than
-# hacking their Makefile.am.
-nobase_opal_HEADERS += libltdl/ltdl.h
 endif
 
 include class/Makefile.am