Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response_ends_trial: false functionality for visual-search-circle #3210

Closed
derekalbert opened this issue Jan 14, 2024 · 6 comments · Fixed by #3211
Closed

response_ends_trial: false functionality for visual-search-circle #3210

derekalbert opened this issue Jan 14, 2024 · 6 comments · Fixed by #3211

Comments

@derekalbert
Copy link

Hi, I'm using the visual-search-circle plugin and want to have the trial last its full duration (as per trial_duration) despite participants entering a response. That is to say, it would be great to have response_ends_trial: false functionality in this plugin. I am trying to modify the plugin myself using logic from html-keyboard-response, but struggling. Id really appreciate some help!

@jodeleeuw
Copy link
Member

Caught me at a good time for this 😁 - I just added this feature in #3211. It'll be live on npm in a bit.

@jodeleeuw
Copy link
Member

Updating to version 1.2.0 should add the feature.

@derekalbert
Copy link
Author

Thank you!

@derekalbert
Copy link
Author

derekalbert commented Jan 14, 2024

Hi Jo, I'm trying the plugin but there seems to be an issue. Now, the arrays pile up. Maybe they aren't properly getting cleared from the screen?

@derekalbert
Copy link
Author

I re-added the clear_display function from the previous version to this new one and called it prior to all instances of end_trial. This seems to have fixed the problem. Will let you know if I come across others.

function clear_display() {
display_element.innerHTML = "";
}

@jodeleeuw
Copy link
Member

Oops. I'll publish a fix for this. Thanks for flagging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants